Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-11497] Socket connection management #8

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

[DEV-11497] Socket connection management #8

wants to merge 54 commits into from

Commits on Aug 6, 2024

  1. Removes unused PhoenixRawSocket

    @kpsroka
    kpsroka committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    46ed4e3 View commit details
    Browse the repository at this point in the history

  2. Revamp of the PhoenixSocket library.

    @kpsroka
    kpsroka committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a394dfb View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Simplify and correct

    @kpsroka
    kpsroka committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3722cec View commit details
    Browse the repository at this point in the history

  2. Improves heartbeat handling

    @kpsroka
    kpsroka committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3788e7c View commit details
    Browse the repository at this point in the history

  3. Final touches (lots of them)

    @kpsroka
    kpsroka committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    26b0ba7 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Even more improvements!

    @kpsroka
    kpsroka committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    dd00743 View commit details
    Browse the repository at this point in the history

  2. Simplify, document, and improve

    @kpsroka
    kpsroka committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2824513 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into nextgen

    @kpsroka
    kpsroka committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f639b9b View commit details
    Browse the repository at this point in the history

  4. More simplification

    @kpsroka
    kpsroka committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    335b233 View commit details
    Browse the repository at this point in the history

  5. Reverting unncessary pubspec change

    @kpsroka
    kpsroka committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d4bf5df View commit details
    Browse the repository at this point in the history

  6. Fixing lastState bug.

    @kpsroka
    kpsroka committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f9def19 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Simplification+name adjustments

    @kpsroka
    kpsroka committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    451a6a7 View commit details
    Browse the repository at this point in the history

  2. add timeout to websocket connection and socket heartbeat (braverhealt… 

    …h#86)

* add timeout to websocket connection and socket heartbeat

* added timeout to WebSocket ready future

* closing sink before assigning null to ws

* cancel heartbeat when socket is disposed
    @Neelansh-ns
    Neelansh-ns authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    25fa1da View commit details
    Browse the repository at this point in the history

  3. Some initial tests for SocketConnectionManager

    @kpsroka
    kpsroka committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2562f10 View commit details
    Browse the repository at this point in the history

  4. Renames _isConnected to _isOpen

    @kpsroka
    kpsroka committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    21b603f View commit details
    Browse the repository at this point in the history

  5. Adds more comments

    @kpsroka
    kpsroka committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    758bac5 View commit details
    Browse the repository at this point in the history

  6. Fixing some tests

    @kpsroka
    kpsroka committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    be87621 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Fixes: test fixes

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    eeab8de View commit details
    Browse the repository at this point in the history

  2. Isolating setups in SocketConnectionTest

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    da93bc5 View commit details
    Browse the repository at this point in the history

  3. Closes _socketStateStream in PhoenixSocket.dispose()

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6c27b0e View commit details
    Browse the repository at this point in the history

  4. Restructures SocketConnectionAttempt

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    aaf981b View commit details
    Browse the repository at this point in the history

  5. Renames socket states

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0d6ba23 View commit details
    Browse the repository at this point in the history

  6. Removes rescheduling of heartbeat on message sent.

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5e61293 View commit details
    Browse the repository at this point in the history

  7. Rewrites addMessage for clarity.

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0c7464a View commit details
    Browse the repository at this point in the history

  8. s/timout/timeout/

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    cb56172 View commit details
    Browse the repository at this point in the history

  9. Awaits on heartbeat message to catch cases where sendMessage would th… 

    …row before adding message to sink
    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    893d60b View commit details
    Browse the repository at this point in the history

  10. Makes integration tests more appopriate

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ca28589 View commit details
    Browse the repository at this point in the history

  11. Updates comment on WebSocketConnectionState.

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1b934cd View commit details
    Browse the repository at this point in the history

  12. Minor improvements

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0e9637f View commit details
    Browse the repository at this point in the history

  13. Removes unnecessary 4000 code

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    eb8ada3 View commit details
    Browse the repository at this point in the history

  14. isConnected -> isOpen

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9468fac View commit details
    Browse the repository at this point in the history

  15. Makes _currentAttempt nullable

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f1ff37a View commit details
    Browse the repository at this point in the history

  16. Removing one await

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a10ca41 View commit details
    Browse the repository at this point in the history

  17. Joins two if clauses

    @kpsroka
    kpsroka committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    069b56b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Restructuring lifetime

    @kpsroka
    kpsroka committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    466875c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Updates comments

    @kpsroka
    kpsroka committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    30a397e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Refactors PhoenixSocket.sendMessage to get better control over heartbeat

    @kpsroka
    kpsroka committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    77a41bb View commit details
    Browse the repository at this point in the history

  2. Avoids unnecessary _maybeConnect() in SocketConnectionManager.start()

    @kpsroka
    kpsroka committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9ecf278 View commit details
    Browse the repository at this point in the history

  3. Updates mocks

    @kpsroka
    kpsroka committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    bcafd10 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'master' into nextgen

    @kpsroka
    kpsroka authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4d96d47 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Small improvements in PhoenixException

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    1e14a29 View commit details
    Browse the repository at this point in the history

  2. Fixes order of operation on socket close

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b8e69b8 View commit details
    Browse the repository at this point in the history

  3. Adds timeout to ws.ready

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    dd7208e View commit details
    Browse the repository at this point in the history

  4. Avoids duplicating close events

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    64bce8b View commit details
    Browse the repository at this point in the history

  5. Fixing PhoenixSocket's close/dispose

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5892858 View commit details
    Browse the repository at this point in the history

  6. Updates tearDown in channel_integration_tests.dart

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    79c0e99 View commit details
    Browse the repository at this point in the history

  7. Removes obsolete tests

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    aac862f View commit details
    Browse the repository at this point in the history

  8. Updates mocks

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    f2aab67 View commit details
    Browse the repository at this point in the history

  9. Replaces MockPhoenixSocketOptions with actual object

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    bb46924 View commit details
    Browse the repository at this point in the history

  10. Adding socket.dispose to integration tests, fixing one test

    @kpsroka
    kpsroka committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b96c2d5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Updates range of DelayedCallback._id to be JS-compatible

    @kpsroka
    kpsroka committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    97cfb6f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Makes failed heartbeat not attempt to reconnect after ConnectionManag… 

    …er is closed or disposed
    @kpsroka
    kpsroka committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f633357 View commit details
    Browse the repository at this point in the history

  2. Makes tests run non-concurrently

    @kpsroka
    kpsroka committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d87e620 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #10 from superlistapp/fix/dev-11757-stateerror-bad… 

    …-state-cannot-reconnect-a-disposed-socket

[part of DEV-11757] Makes failed heartbeat not attempt to reconnect after ConnectionManager is closed or disposed
    @kpsroka
    kpsroka authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    28b0006 View commit details
    Browse the repository at this point in the history