Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor] Add test to demonstrate that changing layer builders does not re-layout #2388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 103 additions & 0 deletions super_editor/test/super_editor/supereditor_theme_switching_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter_test_runners/flutter_test_runners.dart';
import 'package:super_editor/super_editor.dart';
import 'package:super_editor/super_editor_test.dart';

import 'test_documents.dart';

void main() {
group('SuperEditor > theme switching', () {
testWidgetsOnArbitraryDesktop('switches caret color', (tester) async {
final brightnessNotifier = ValueNotifier<Brightness>(Brightness.light);

await _pumpThemeSwitchingTestApp(tester, brightnessNotifier: brightnessNotifier);

// Place the caret at the beginning of the paragraph.
await tester.placeCaretInParagraph('1', 0);

// Ensure the caret is green, because the theme is light.
expect(_findDesktopCaretColor(tester), Colors.green.shade500);

// Switch the theme to dark.
brightnessNotifier.value = Brightness.dark;
await tester.pumpAndSettle();

// Ensure the caret is red, because the theme is dark.
expect(_findDesktopCaretColor(tester), Colors.red.shade500);
});

testWidgetsOnArbitraryDesktop('switches caret color after typing', (tester) async {
final brightnessNotifier = ValueNotifier<Brightness>(Brightness.light);

await _pumpThemeSwitchingTestApp(tester, brightnessNotifier: brightnessNotifier);

// Place the caret at the beginning of the paragraph.
await tester.placeCaretInParagraph('1', 0);

// Ensure the caret is green, because the theme is light.
expect(_findDesktopCaretColor(tester), Colors.green.shade500);

// Switch the theme to dark.
brightnessNotifier.value = Brightness.dark;
await tester.pumpAndSettle();

// Type a character to trigger a re-layout.
await tester.typeImeText('a');

// Ensure the caret is red, because the theme is dark.
expect(_findDesktopCaretColor(tester), Colors.red.shade500);
});
});
}

/// Pumps a widget tree that rebuilds when the [brightnessNotifier] changes.
///
/// The widget tree contains a [SuperEditor] with a custom caret overlay that
/// changes color based on the brightness of the theme.
Future<void> _pumpThemeSwitchingTestApp(
WidgetTester tester, {
required ValueNotifier<Brightness> brightnessNotifier,
}) async {
final composer = MutableDocumentComposer();
final editor = createDefaultDocumentEditor(
document: singleParagraphDoc(),
composer: composer,
);

await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: ValueListenableBuilder(
valueListenable: brightnessNotifier,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this widget tree, I'm a little confused about the build behavior.

Your description of the problem is that the overlay builders don't rebuild when the brightness changes.

I'm reading through this tree. I see the ValueListenableBuilder, which rebuilds whenever the brightness changes. When the ValueListenableBuilder rebuilds, it should construct a new SuperEditor instance, which then creates a new DefaultCaretOverlayBuilder. If we're rebuilding the ValueListenableBuilder, and rebuilding the SuperEditor, why isn't the DefaultCaretOverlayBuilder being built?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because none of the document nodes changed its content. Thus, we are not running another layout phase. We are only repainting the document components, without running a layout phase ContentLayers won't build the overlayers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you phrase that statement in terms of the chain of events that I described? What did I get wrong in that series of events? It's not clear what "none of the document nodes changed" has to do with my comment. If we're rebuilding SuperEditor then why isn't SuperEditor running build on its internal ContentLayers? Where are those two builds getting disconnected, such that SuperEditor runs widget build, but ContentLayers doesn't?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sequence of methods being called:

-> INITIAL BUILD
ValueListenableBuilder -> build
SuperEditor -> build
DocumentScaffold -> build
RenderContentLayers -> performLayout
ContentLayersElement -> buildLayers
RenderContentLayers -> performLayout
ContentLayersElement -> buildLayers

-> VALUE NOTIFIER CHANGED 
ValueListenableBuilder -> build
SuperEditor -> build
DocumentScaffold -> build
ContentLayersElement -> update

The critical thing for us is that RenderContentLayers.performLayout is not called. It seems the subtree isn't considered dirty, so the layout does not run again.

builder: (context, brightness, child) {
return Theme(
data: ThemeData(
brightness: brightness,
),
child: SuperEditor(
editor: editor,
documentOverlayBuilders: [
// Copy all default overlay builders except the caret overlay builder.
...defaultSuperEditorDocumentOverlayBuilders.where(
(builder) => builder is! DefaultCaretOverlayBuilder,
),
DefaultCaretOverlayBuilder(
caretStyle: CaretStyle(
color: brightness == Brightness.light ? Colors.green : Colors.red,
),
)
],
),
);
},
),
),
),
);
}

Color _findDesktopCaretColor(WidgetTester tester) {
final caret = tester.widget<Container>(find.byKey(DocumentKeys.caret));
return (caret.decoration as BoxDecoration).color!;
}
Loading