Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.jinja #2407

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update index.jinja #2407

wants to merge 2 commits into from

Conversation

suragch
Copy link

@suragch suragch commented Nov 15, 2024

Fix text to copy when the button is pressed. It should copy the shown text. An even better solution would be to make a single source of truth for both the shown text and the copied text.

This PR also fixes a broken link to the SuperEditor Quickstart guides.

@@ -213,8 +213,8 @@ layout:

<script>
function copyActivationToClipboard() {
navigator.clipboard.writeText("dart pub global activate static_shock_cli");
navigator.clipboard.writeText("super_editor: ^0.2.7");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be injectable. Can you locate the code that shows the value in the header? The value should be coming from the GitHub plugin, and injected through a Jinja variable. You should be able to use that same injection here for "^0.2.7".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants