Support for hyphenated component names #301
Open
+160
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A candidate fix for:
#296
Not sure if you'll like this solution, as it's pragmatic rather than being 100% robust...
Other solutions I considered:
So having ruled out those two approaches, I ended up using A-Frame utils styleParser.parse, and then patching up the results as best I could.
As per the comments in the index.js file, that's not a 100% robust solution, but much better than the current implemetation. The problematic cases are all fairly pathological...