Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to compile with multibyte characters #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix to compile with multibyte characters #32

wants to merge 1 commit into from

Conversation

shirosaki
Copy link

If a source file contains multibyte characters (Japanese characters),
Check Syntax or Display JavaScript fails with UnicodeEncodeError on
Windows. Adding encode/decode with utf-8 works without errors.

I got the following error messages with multibyte characters source file.

Traceback (most recent call last):
  File ".\sublime_plugin.py", line 356, in run_
  File ".\CoffeeScript.py", line 90, in run
  File ".\CoffeeScript.py", line 32, in brew
  File ".\CoffeeScript.py", line 14, in run
  File ".\subprocess.py", line 701, in communicate
  File ".\subprocess.py", line 911, in _communicate
UnicodeEncodeError: 'ascii' codec can't encode characters in position 21-23: ordinal not in range(128)

@shirosaki
Fix to compile with multibyte characters
710f83d 
If a source file contains multibyte characters (Japanese characters),
Check Syntax or Display JavaScript fails with UnicodeEncodeError on
Windows. Adding encode/decode with utf-8 works without errors.
I've tested this on Windows and OS X.
@LYY
Copy link

LYY commented Apr 23, 2013

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirosaki @LYY