Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting garbage file #1

Open
wants to merge 2 commits into
base: 17.1-dev
Choose a base branch
from
Open

Deleting garbage file #1

wants to merge 2 commits into from

Conversation

suzanne-lee
Copy link
Owner

This pull request [DESCRIBE WHAT THIS PULL REQUEST IS TRYING TO ACCOMPLISH HERE]. It [DESCRIBE HOW IT ACCOMPLISHES THE GOAL HERE].

See also: [PROVIDE REFERENCES TO OTHER TICKETS, PULL REQUESTS, OR MAILING LIST THREADS HERE. OPTIONAL.]

suzanne-lee pushed a commit that referenced this pull request Jun 18, 2019
Under Proband Information tab, when setting DoB Proband to dates later than today, error message read "Consent to Study date cannot be later than today". Error message now updated to reflect the proper field triggering the error.

#1 of https://redmine.cbrain.mcgill.ca/issues/13767
suzanne-lee pushed a commit that referenced this pull request Nov 9, 2021
Fix error

```
PHP Fatal error: Uncaught TypeError: NDB_BVL_Instrument::factory(): Argument #1 ($loris) must be of type LORIS\LORISInstance, string given, called in /var/www/Loris/tools/CouchDB_Import_Instruments.php on line 196 and defined in /var/www/Loris/php/libraries/NDB_BVL_Instrument.class.inc:225
```

In CouchDB_Import_Instruments.php

Fixes aces#7680
suzanne-lee pushed a commit that referenced this pull request Nov 9, 2021
When accessing an instrument from RB, I got the error:

```
Fatal error: Uncaught TypeError: Argument 1 passed to ValidatableIdentifier::__construct() must be of the type string, null given, called in
/home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc on line 2863 and defined in /home/driusan/Code/Loris/php/libraries/Valida
tableIdentifier.php:57 Stack trace: #0 /home/driusan/Code/Loris/php/libraries/NDB_BVL_Instrument.class.inc(2863): ValidatableIdentifier->__co
nstruct(NULL) #1 /home/driusan/Code/Loris/src/Middleware/UserPageDecorationMiddleware.php(241): NDB_BVL_Instrument->handle(Object(Laminas\Dia
ctoros\ServerRequest)) aces#2 /home/driusan/Code/Loris/src/Middleware/PageDecorationMiddleware.php(57): LORIS\Middleware\UserPageDecorationMiddle
ware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) aces#3 /home/driusan/Code/Loris/php/libraries/NDB_Page.cl
ass.inc(735): LORIS\Middleware\PageDecorationMiddleware->process(Object(Laminas\Diactoros\ServerRequest), Object(NDB_BVL_Instrument_aosi)) aces#4
 /home/driusan/Code/Loris/php/libraries/NDB_BVL_In in /home/driusan/Code/Loris/php/libraries/ValidatableIdentifier.php on line 57
```

This fixes the type error so that the instrument page loads.
ridz1208 added a commit that referenced this pull request Mar 28, 2023
This fixes the error:

```
<b>Fatal error</b>:  Uncaught TypeError: ValidatableIdentifier::__construct(): Argument #1 ($value) must be of type string, int given, called in /var/www/loris/modules/behavioural_qc/php/models/incompletedto.class.inc on line 126
```

when the module is run on PHP 8.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant