fix: move cursor pointer style on panel header to the clickable part #864
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The playground console header's toggle button has no
cursor: pointer
but its noninteractive wrapper div does, this moves the style to the button. The current behavior makes the non-clickable part appear clickable and the button not.An alternative would be to just delete
cursor: pointer;
if that was the desired aesthetic but it would be less clear on desktop what's clickable. I think a small improvement, that also makes just deleting the line better, would be to move the.panel-header
wrapper's padding to be a child concern, allowing the.panel-heading
button to haveheight: 100%
to fill its container.I tried the padding change but the component is used in two places and slotted sibling styles are a bit tricky to get right, and I couldn't test the other place because Firefox/Chromium on Linux are erroring with
SvelteKitError: Not found: /node_modules/.vite/deps/bindings_wasm_bg.wasm
and in the browserCompileError: WebAssembly.instantiate(): expected magic word ...
, I think related to this Vite issue - vitejs/vite#8427Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.