-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Define the MountOptions type #13674
Conversation
🦋 Changeset detectedLatest commit: cdfa314 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is backwards.
There also seems to be some parentheses missing here: intro?: boolean;
- } & {} extends Props ? {
+ } & ({} extends Props ? {
/**
* Component properties.
*/
props?: Props;
} : {
/**
* Component properties.
*/
props: Props;
- }
+ }) |
I see, so |
Agreed, it's a bit odd... |
You could add a |
Thanks for the hand holding. Appreciated. If I can bother you for one more thing: How is the changeset generated? Never used this before. Any link for a quick tutorial? |
The bot posted a link in its comment, also never dealt with them. |
Shoot! I did not notice. Alright, I think I'm all set then. Cheers! |
Ok, I think I'm done. |
Looks good to my non-maintainer eyes, don't forget to publish this as a proper PR. |
Meaning taking it out of draft mode? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Please could you run |
@webJose I'll update your PR. |
Thanks! Very kind of you. Much appreciated. |
Svelte 5 rewrite
Closes #13655.
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint