Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure muted DOM property works correctly in FF #13751

Merged
merged 5 commits into from
Oct 23, 2024
Merged

fix: ensure muted DOM property works correctly in FF #13751

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ae56ff
fix: ensure muted DOM property works correctly in FF
trueadm Oct 21, 2024
b11f314
update test
trueadm Oct 21, 2024
a33564a
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
benmccann Oct 21, 2024
9e56c1d
feedback
trueadm Oct 22, 2024
cacd1f1
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
trueadm Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-timers-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure muted DOM property works correctly in FF
4 changes: 3 additions & 1 deletion packages/svelte/src/compiler/phases/2-analyze/visitors/RegularElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ export function RegularElement(node, context) {

if (
node.attributes.some(
(attribute) => attribute.type === 'Attribute' && attribute.name === 'autofocus'
(attribute) =>
attribute.type === 'Attribute' &&
(attribute.name === 'autofocus' || attribute.name === 'muted')
)
) {
mark_subtree_dynamic(context.path);
Expand Down
6 changes: 6 additions & 0 deletions packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ export function RegularElement(node, context) {
if (
!is_custom_element &&
attribute.name !== 'autofocus' &&
attribute.name !== 'muted' &&
(attribute.value === true || is_text_attribute(attribute))
) {
const name = get_attribute_name(node, attribute);
Expand Down Expand Up @@ -530,6 +531,11 @@ function build_element_attribute_update_assignment(element, node_id, attribute,
return false;
}

if (name === 'muted') {
trueadm marked this conversation as resolved.
Show resolved Hide resolved
state.init.push(b.stmt(b.assignment('=', b.member(node_id, b.id('muted')), value)));
return false;
}

/** @type {Statement} */
let update;

Expand Down
2 changes: 1 addition & 1 deletion packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/fragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ function is_static_element(node) {
return false;
}

if (attribute.name === 'autofocus') {
if (attribute.name === 'autofocus' || attribute.name === 'muted') {
return false;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/svelte/tests/css/samples/omit-scoping-attribute-attribute-selector/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<div><video class="svelte-xyz" autoplay muted></video>
<video muted></video></div>
<div><video class="svelte-xyz" autoplay></video>
<video></video></div>