fix: broken property name derivation in keyframe generation #13820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 93b54f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zaninime
force-pushed
the
push-kozrppytnssx
branch
from
47cc91d to
93b54f9
Compare
dummdidumm
approved these changes
Oct 23, 2024
| 'svelte': patch | ||
| --- | ||
|
|
||
| Fix property name conversion in custom transitions |
There was a problem hiding this comment.
Suggested change
| Fix property name conversion in custom transitions | |
| fix: adjust property name conversion in custom transitions |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom CSS properties are being renamed in Svelte 5 while used inside custom transitions. This was working fine in Svelte 4, and I just stumbled across an error in this code. The failure uncovered that these cases were not handled correctly.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lintUnrelated tests are failing on my machine (runtime-runes).