Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add empty stack to CompileDiagnostic to show error on build #13942

Merged
merged 5 commits into from
Oct 26, 2024

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Oct 25, 2024

As discussed in #13937 i'm adding an empty stack trace to the error to show the frame and info on the error if the build fails.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: d1f4beb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 25, 2024

pnpm add https://pkg.pr.new/svelte@13942

commit: d1f4beb

@dummdidumm
Copy link
Member

We should add a note why we do that

@paoloricciuti
Copy link
Member Author

We should add a note why we do that

Added... I'm sure I wrote the comment before, not sure why it was not committed

@paoloricciuti paoloricciuti merged commit 7be3afb into main Oct 26, 2024
10 checks passed
@paoloricciuti paoloricciuti deleted the add-empty-stack branch October 26, 2024 07:20
@github-actions github-actions bot mentioned this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants