Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more exhaustive check during SvelteMap.set in deriveds #13951

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

paoloricciuti
Copy link
Member

Closes #13947 ...i'm not sure this is the right fix and i'm not sure of the performance implications. The problem is that basically just checking for null and !null is not enough. In this case both have a reaction because of the second variable read but not every reaction in s are in version.

This seems to fix the issue and tests are green but i have the feeling this could overfire the increase of version.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 26, 2024

🦋 Changeset detected

Latest commit: 59435ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 26, 2024

pnpm add https://pkg.pr.new/svelte@13951

commit: 59435ac

@paoloricciuti paoloricciuti force-pushed the better-check-for-sveltemap-set branch from f156fdb to 88a84ff Compare October 26, 2024 17:12
@trueadm trueadm force-pushed the better-check-for-sveltemap-set branch from 88a84ff to c399e14 Compare October 26, 2024 17:13
@paoloricciuti paoloricciuti force-pushed the better-check-for-sveltemap-set branch from c399e14 to 59435ac Compare October 26, 2024 17:13
@paoloricciuti paoloricciuti merged commit 67cf387 into main Oct 26, 2024
10 checks passed
@paoloricciuti paoloricciuti deleted the better-check-for-sveltemap-set branch October 26, 2024 17:18
@github-actions github-actions bot mentioned this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteMap reactivity not fully fixed by #13877
2 participants