-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pkg.pr.new
comment workflow
#14156
Conversation
|
preview: https://svelte-dev-git-preview-svelte-14156-svelte.vercel.app/ this is an automated message |
Might need to remove the path on the pr workflow too. I would I would also add an ls in this workflow in case it doesn't work. |
Ah |
Should we try @pngwn ? |
Yeah. Go for it. |
@@ -37,4 +37,6 @@ jobs: | |||
uses: actions/upload-artifact@v4 | |||
with: | |||
name: output.json | |||
path: output.json | |||
path: ./output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw this. I'm pretty sure this needs to be the path to the file you want to save, I don't think this will actually save the JSON file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is just a reference, it can be anything, more like an id. Path is the thing that determines what gets saved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* fix: `pkg.pr.new` comment workflow * chore: remove path from initial workflow and add ls * chore: add path back since it's mandatory
Let's try to fix this workflow, this both address @pngwn comment about the context and the output that made it fail...it should work now, not sure how to test it or check
ls
without merging tho.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint