Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pkg.pr.new comment workflow #14156

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

paoloricciuti
Copy link
Member

Let's try to fix this workflow, this both address @pngwn comment about the context and the output that made it fail...it should work now, not sure how to test it or check ls without merging tho.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 20659d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14156-svelte.vercel.app/

this is an automated message

@pngwn
Copy link
Member

pngwn commented Nov 5, 2024

Might need to remove the path on the pr workflow too.

I would ls -R . in the pr workflow just to see exactly where that file is being created.

I would also add an ls in this workflow in case it doesn't work.

@pngwn
Copy link
Member

pngwn commented Nov 5, 2024

Ah

@paoloricciuti
Copy link
Member Author

Ah

Should we try @pngwn ?

@pngwn
Copy link
Member

pngwn commented Nov 5, 2024

Yeah. Go for it.

@paoloricciuti paoloricciuti merged commit f1f4c29 into main Nov 5, 2024
11 checks passed
@paoloricciuti paoloricciuti deleted the fix-comment-pkg-pr-new branch November 5, 2024 14:03
@@ -37,4 +37,6 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: output.json
path: output.json
path: ./output
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this. I'm pretty sure this needs to be the path to the file you want to save, I don't think this will actually save the JSON file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is just a reference, it can be anything, more like an id. Path is the thing that determines what gets saved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trueadm pushed a commit that referenced this pull request Nov 7, 2024
* fix: `pkg.pr.new` comment workflow

* chore: remove path from initial workflow and add ls

* chore: add path back since it's mandatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants