Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pre tag with single \n incorrect hydration #14783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paoloricciuti
Copy link
Member

Closes #14767

This is a super weird one...basically calling firstChild on a pre tag where the first text node is a single \n skips the \n completely. This meant that a code like this

<script>
	let name = $state('');
</script>

<pre>
<div><span>{name}</span></div>
</pre>

was incorrectly compiled to have

var pre = root();
var div = $.sibling($.child(pre));

but $.child was already returning the div.

This is not something we do, the browser does this as you can see in this codepen so we have to special case it. However this meant that the check for hydration mismatch on reset was wrong to so i had to compensate there too.

Finally for an extra bit of weirdness, the \n is literally removed from innerHTML too (also tested in the codepen) so in the test i had to specify an _expected.html.

All of this feels very weird and kinda brittle to me but i don't know if there's a better solution. WDYT?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 24dccce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal invocation with snippet & action
1 participant