Remove orphan pluralizations #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the same code to be used in thor and rspec
Check that they are no pluralization files that do not have a corresponding locale.yml file Also enabled both Rspec should and expect syntax
Deleted 48 orphan pluralizations that do not have a corresponding locale file.
Remove pluralization specs for orphan pluralizations since these pluralizations have been deleted
Existing orphans have been deleted. The CI should fail if new orphans are added.
Added list of removed pluralizations to the README.
|
Thank you! |
kevindew
added a commit
to alphagov/govuk_app_config
that referenced
this pull request
Nov 15, 2022
The 7.0.6 release of rails-i18n dropped support for a number of plurals [1] and this causes our apps that make use of these languages to error and thus be unable to update to rails-i18n 7.0.6 This commit ports over these rules from rails-i18n to maintain the behaviour. There is also something of a duplicate of this file in [rails_translation_manager](https://github.com/alphagov/rails_translation_manager/blob/main/config/locales/plurals.rb) that may also need an update. I'm unsure of the status of that file though as it is already out-of-sync with this one and I think this one takes priority. [1]: svenfuchs/rails-i18n#1017
chao-xian
added a commit
to alphagov/rails_translation_manager
that referenced
this pull request
Nov 16, 2022
The 7.0.6 release of rails-i18n dropped support for a number of plurals [1] and this causes our apps that make use of these languages to error and thus be unable to update to rails-i18n 7.0.6 This commit ports over these rules from rails-i18n to maintain the behaviour. This update follows what was added into govuk_app_config [2] [1]: svenfuchs/rails-i18n#1017 [2]: alphagov/govuk_app_config#266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1011 #577