Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BaseApiListingResource when concurrent execution #3206

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

awojcicki
Copy link

@awojcicki awojcicki commented May 22, 2019

In some scenarios process method doesn't return proper Swagger definition (scan isn't performed)

Sample replication scenario:

  • two threads are inside process method
  • new empty Swagger instance is created for both on them
  • synchronized block is fired for first one producing correct swagger and marks as initialized
  • seconds thread starts synchronized block but because it was marked as initialized scan is not performed
  • second thread returns incorrect swagger definition

@awojcicki
Copy link
Author

@frantuma hey, we identified issue in BaseApiListingResource If you have some time please take a look on this fix. Thank you!

@frantuma frantuma merged commit 1dee776 into swagger-api:1.5 Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants