Gh actions v31 setup #128
Merged
Gh actions v31 setup #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantuma
requested changes
Mar 18, 2024
| branches: ["v31"] | ||
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: ["master"] |
.github/workflows/deploy-docker.yml
Outdated
| NAMESPACE_NAME="swagger-oss" | ||
| K8S_OBJECT_TYPE="daemonsets" | ||
| K8S_OBJECT_NAME="swagger-petstore-31" | ||
| DEPLOY_IMAGE="swaggerapi/swagger-petstore31:$SC_RELEASE_TAG" |
There was a problem hiding this comment.
check tags and image name in dockerhub, this is wrong, should be swaggerapi/petstore31. Also wrong in corresponding file in master and possibly v2
CI/docker-release.sh
Outdated
| docker push $DOCKER_PETSTORE_IMAGE_NAME:$SC_RELEASE_TAG | ||
| docker push $DOCKER_PETSTORE_IMAGE_NAME:latest | ||
| echo "docker images:" | ||
| docker images | grep -i petstore3 |
| mvn versions:set -DnewVersion=$SC_VERSION | ||
| mvn versions:commit | ||
|
|
||
| ##################### |
There was a problem hiding this comment.
this is meant to go through all files which have a ref to the version and update accordingly.
In case of v31 there are many. Do a search for 1.0.3 and add here the corresponding update scripts (test locally)
ALSO: need to update first manually everything to 1.0.4-SNAPSHOT, including pom
CI/publishRelease.py
Outdated
| id = lastReleaseId(tag) | ||
| payload = "{\"tag_name\":\"" + tag + "\", " | ||
| payload += "\"draft\":" + "false" + ", " | ||
| payload += "\"target_commitish\":\"" + "master" + "\"}" |
CI/releaseNotes.py
Outdated
| result = "" | ||
|
|
||
| baseurl = "https://api.github.com/repos/swagger-api/swagger-petstore/pulls/" | ||
| content = ghApiClient.readUrl('repos/swagger-api/swagger-petstore/pulls?state=closed&base=master&per_page=100') |
There was a problem hiding this comment.
wrong branch?
generally recheck all ref to branches not to point to master but to correct one
CI/releaseNotes.py
Outdated
| payload += "\"body\":" + json.dumps(content) + ", " | ||
| payload += "\"draft\":" + "true" + ", " | ||
| payload += "\"prerelease\":" + "false" + ", " | ||
| payload += "\"target_commitish\":\"" + "master" + "\"}" |
frantuma
requested changes
Mar 18, 2024
| python $CUR/CI/publishRelease.py "$SC_RELEASE_TAG" | ||
|
|
||
| ##################### | ||
| ### update the version to next snapshot in maven project with set version |
There was a problem hiding this comment.
like in prepare release address all needed files
frantuma
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.