Make it clear that git status is introduced in Episode 3 (issue #685) #686
Conversation
…pentry#685) - actually teach the good practice of running ``git status`` before ``git init`` to avoid nested repositories - be clear that ``git status`` is introduced in Episode 3, not 4 - show the contents of a .git sub-directory - minor re-wordings in Episode 3
|
Hey @jdvorak001 thanks for the review request! I'm sorry it's taken a bit to get to your PR. I'll do my best to get to it this week! |
There was a problem hiding this comment.
I don't think that starting with explaining nested repositories is the best introduction to Git for new learners. It seems like they should first learn out to initialize a repository and what that means, then a little later have them do a thought experiment as to what should be made into repositories.
|
Thanks for the review. It certainly is not the intent of this path to explain nested repositories, let alone promote them. It just warns against them (as does the currently released version). What I tried to plant is the good practice of running |
There was a problem hiding this comment.
This PR basically moves the "Places to Create Git Repositories" exercise into the lesson prior to learners first initializing a repository. I don't agree with the change because learners do not have the framework of initializing repositories on which to add the concept of nested repositories.
|
|
||
| It is good practice to first check if this is a good place to do so: | ||
| a new repository shall not be nested in another repository placed higher up the directory hierarchy. |
There was a problem hiding this comment.
this sentence introduces topic of nested repositories. Learners will ask, "what does that mean" and "why shouldn't we do that" which is explained later in the lesson.
|
I'm going to close this PR in preparation of the new workbench lesson architecture, but with the following points which halted the original merging of this PR. PRs should be limited to one issue per PR. This PR attempted to do many things, and so the original issue - introducing |
I am suggesting this fix to issue #685.