Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing links in episodes 06 and 07 #582

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Jul 6, 2023

Fixes missing links in episodes 06 and 07. Also fixes #580.

Most of the links are taken from this version of links.md as that file has since been removed from this repo.

Extra changes:

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-inflammation/compare/md-outputs..md-outputs-PR-582

The following changes were observed in the rendered markdown documents:

 05-cmdline.md             |  4 ++--
 06-best-practices-R.md    |  7 ++++++-
 07-knitr-R.md             |  4 ++--
 15-supp-loops-in-depth.md |  4 ++--
 md5sum.txt                | 50 +++++++++++++++++++++++------------------------
 5 files changed, 37 insertions(+), 32 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-06 14:14:58 +0000

github-actions bot pushed a commit that referenced this pull request Jul 6, 2023
@Bisaloo Bisaloo merged commit 4110831 into swcarpentry:main Jul 10, 2023
@Bisaloo
Copy link
Member

Bisaloo commented Jul 10, 2023

Thanks!

@zkamvar
Copy link
Contributor

zkamvar commented Jul 10, 2023

Thank you for addressing this @elichad! I realize now that I didn't port over links.md during the transition 😳 because it was in the _includes folder, which were mostly template documents.

@Bisaloo, if you have any links that you want to use across multiple pages in the future, you can add them in a links.md document in the home folder and they will be available for the entire lesson. I realized that I had never documented it 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links need to be fixed in CONTRIBUTING.md
3 participants