Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DocumentRangeFormattingRequest #1806

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

MahdiBM
Copy link
Contributor

@MahdiBM MahdiBM commented Nov 5, 2024

partially resolves #1805

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @MahdiBM. It’s looking great. I have left a few comments inline and I think they should also fix your issue that you don’t get any edits.

Sources/SourceKitLSP/Swift/DocumentFormatting.swift Outdated Show resolved Hide resolved
Sources/SourceKitLSP/Swift/DocumentFormatting.swift Outdated Show resolved Hide resolved
Sources/SourceKitLSP/Swift/DocumentFormatting.swift Outdated Show resolved Hide resolved
Tests/SourceKitLSPTests/RangeFormattingTests.swift Outdated Show resolved Hide resolved
@MahdiBM
Copy link
Contributor Author

MahdiBM commented Nov 6, 2024

Ok I think the PR is looking good ... I'll mark as ready for review after I've added more tests.

@MahdiBM MahdiBM requested a review from ahoppen November 6, 2024 18:16
@MahdiBM MahdiBM marked this pull request as ready for review November 6, 2024 18:17
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for implementing this @MahdiBM. Changes look great to me.

@ahoppen
Copy link
Member

ahoppen commented Nov 6, 2024

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Nov 6, 2024

@swift-ci Please test Windows

auto-merge was automatically disabled November 8, 2024 11:55

Head branch was pushed to by a user without write access

@ahoppen
Copy link
Member

ahoppen commented Nov 8, 2024

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Nov 8, 2024

@swift-ci Please test Windows

@ahoppen ahoppen merged commit 3a18960 into swiftlang:main Nov 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle "textDocument/rangeFormatting" and "textDocument/onTypeFormatting"
2 participants