[FreeBSD] Fix FreeBSD build/support #1075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-yuji
commented
Dec 9, 2024
michael-yuji
commented
- Use "/usr/share/zoneinfo" like other platforms
- Use platform specific types and values
- Implement extattr ops for FreeBSD
- Use copy_file_range(2) for file cloning
- all supported FreeBSD (13+) supports it for regular file, and allows for file system level offloading (e.g. ZFS block-cloning, NFS server side copying)
- Use "/usr/share/zoneinfo" - Use platform specific types and values - Implement extattr ops for FreeBSD - Use copy_file_range(2) for file cloning
michael-yuji
changed the title
compnerd
reviewed
Dec 9, 2024
| @@ -142,7 +142,11 @@ final class _ProcessInfo: Sendable { | |||
| let time: UInt64 = ullTime | |||
| #else | |||
| var ts: timespec = timespec() | |||
| #if os(Linux) | |||
There was a problem hiding this comment.
This changes behaviour on Android I believe.
There was a problem hiding this comment.
Fixed to only use CLOCK_MONOTONTIC for FreeBSD and OpenBSD.
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
compnerd
reviewed
Dec 9, 2024
|
@swift-ci please test |
compnerd
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.