Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SF-0007 Subprocess to verision 6 #1105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update SF-0007 Subprocess to verision 6 #1105

wants to merge 1 commit into from

Conversation

iCharlesHu
Copy link
Contributor

@iCharlesHu iCharlesHu commented Dec 23, 2024 •
edited
Loading

Addressed proposal comments from https://forums.swift.org/t/review-2nd-sf-0007-subprocess/76547/26

  • Added a Configuration based overload for runDetached.
  • Updated input types to support: Sequence<UInt8>, Sequence<Data> and AsyncSequence<Data> (dropped AsyncSequence<UInt8> in favor of AsyncSequence<Data>).
  • Added isolation parameter for closure based .run methods.
  • Dropped sending requirement for closure passed to .run.
  • Windows: renamed ProcessIdentifier.processID to ProcessIdentifier.value.
  • Updated TeardownStep to use Duration instead of raw nanoseconds.
  • Switched all generic parameters to full words instead of a letter.

@iCharlesHu iCharlesHu added the proposal This PR is for a proposal label Dec 23, 2024
@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
proposal This PR is for a proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iCharlesHu