Skip to content
This repository has been archived by the owner on Dec 4, 2019. It is now read-only.

Adding Angular 1.6 support #259

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jonshaffer
Copy link

Accounting for lack of $onInit callback in 1.4 #252

jonshaffer and others added 7 commits December 13, 2016 11:02
* Update README.md

Added badges and proper code highlighting.

* Update README.md

Development section pushed to the bottom

* Update README.md

Documented the options.

* Added file icons.css
@jonshaffer
Copy link
Author

jonshaffer commented Dec 16, 2016

Using basic.html as an example you can test angular 1.6 using this branch locally by:

  1. Update systemjs angular to 1.6
  2. Update related demo $http as follows:
$http.get('/demos/data/100.json').success(function(data) {
  $scope.data = data;
});

to

$http.get('/demos/data/100.json').then(function(response) {
  $scope.data = response.data;
});

@jonshaffer jonshaffer changed the title Adding 1.6 support Adding Angular 1.6 support Dec 29, 2016
@zbjornson zbjornson mentioned this pull request Jan 6, 2017
@reinfi
Copy link

reinfi commented Jan 9, 2018

Couldn't this be merged? This would help a lot of people to use this library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants