Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure uploaded image is inserted with correct size #323

Merged
merged 8 commits into from
Jan 28, 2024
Merged

Conversation

swissspidy
Copy link
Owner

@swissspidy swissspidy commented Jan 27, 2024

To-do:

  • Maybe move onSuccess logic so it only runs after thumbnail generation (if thumbnails are generated client-side, that is)
  • Add tests

Fixes #321.

Copy link

github-actions bot commented Jan 27, 2024

Size Change: +128 B (0%)

Total Size: 3.02 MB

ℹ️ View Unchanged
Filename Size Change
build/195.js 2.36 MB 0 B
build/472.js 7.54 kB 0 B
build/541.js 83 kB 0 B
build/blurhash.worker.js 3.21 kB 0 B
build/canvas.worker.js 2.78 kB 0 B
build/chunk-ffmpeg.js 5.89 kB 0 B
build/chunk-selfie-segmentation.js 16.3 kB 0 B
build/dominant-color.worker.js 4.49 kB 0 B
build/ffmpeg.js 1.1 kB 0 B
build/heif.worker.js 424 kB 0 B
build/media-experiments-blocks-rtl.css 298 B 0 B
build/media-experiments-blocks.css 297 B 0 B
build/media-experiments-rtl.css 251 B 0 B
build/media-experiments.css 249 B 0 B
build/media-experiments.js 41.4 kB +56 B (0%)
build/pdf.js 564 B 0 B
build/subtitles.js 861 B 0 B
build/upload-requests-modal-rtl.css 267 B 0 B
build/upload-requests-modal.css 268 B 0 B
build/upload-requests-modal.js 801 B 0 B
build/view-upload-request-view-rtl.css 714 B 0 B
build/view-upload-request-view.css 716 B 0 B
build/view-upload-request.js 16.8 kB +72 B (0%)
build/vips.worker.js 47.7 kB 0 B

compressed-size-action

@swissspidy swissspidy merged commit 61760f4 into main Jan 28, 2024
19 checks passed
@swissspidy swissspidy deleted the fix/321-thumbs branch January 28, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbnails: Ensure uploaded image is inserted with correct size
1 participant