Feature 34: Bug: Verdoppelung von Verweisen #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIL-EBP
approved these changes
Apr 17, 2024
daniel-va
added a commit
that referenced
this pull request
Jun 13, 2024
…g-von-verweisen Feature 34: Bug: Verdoppelung von Verweisen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #34.
Cause: Sibling assets are saved in the database via the
asset_x_asset_ytable. The table has two ids as its fields, one for each sibling. This means that it is possible for a sibling relationship two appear twice, by switching the values of the two id fields. In theory, the API guards against that by deleting duplicates before inserting new entities, but that check was faulty.Fix: We now just delete all entities of
asset_x_asset_ytable that belong to the asset that is being modified, and then immediately insert all correct ones. This ensures that we remove any possible duplicates before even creating them.Note that this does not remove any existing entities, see my comment in #34.