Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80 testing objects #90

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Conversation

mopichalova
Copy link
Collaborator

This pull request aims to close #80. The primary focus is on cleaning up testing objects, unifying model representations, and improving the overall organization of code.

Changes:

Testing objects cleanup

  • testing objects relocated to objects_testing.py to reduce redundancy
  • parsers creation also in objects_testing.py

Text models defined in files

  • text models and regulations identified and moved to text files
  • get_model_str to easily load text models

@xtrojak xtrojak self-requested a review January 5, 2024 08:00
Copy link
Collaborator

@xtrojak xtrojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an excellent job, thank you for this @mopichalova!
Just address the minor issues and we are good to go :)

Testing/objects_testing.py Show resolved Hide resolved
Testing/test_rate.py Outdated Show resolved Hide resolved
@mopichalova
Copy link
Collaborator Author

I also added missing objects and text models for test_vector_model.txt in the commit 7944c7e.

@xtrojak xtrojak merged commit 32cbbcd into sybila:improve-parsing Jan 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants