Insert parsing logic improved #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unsure about raising ComplexParsingError, especially the error that is used for the error message. Can you please check that? |
xtrojak
reviewed
Jan 28, 2024
xtrojak
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert methods (insert_atomic_to_struct, insert_struct_to_complex, insert_atomic_to_complex) fixed in accordance with BCSL.
The changes include ensuring proper matching and handling cases where the replaced agent is unspecified.
Additionally, a new utility function, is_empty, has been added to check if an agent is empty.
Close #72