Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable direct usage of complexes #92

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

mopichalova
Copy link
Collaborator

Close #89 - use complexes directly in abstract_sequence.

Altering cmplx_name to value in the EXTENDED_GRAMMAR enabled us to not only use aliases but also complexes in abstract sequences.

@xtrojak xtrojak linked an issue Jan 31, 2024 that may be closed by this pull request
@xtrojak xtrojak self-requested a review January 31, 2024 09:39
Copy link
Collaborator

@xtrojak xtrojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very elegant solution, I like that!

However, you have to pay attention to the tests. The introduced changes are causing some tests to fail. Also, it would be nice to introduce some new tests focusing specifically on this aspect.

@xtrojak xtrojak merged commit 52f30b5 into sybila:improve-parsing Feb 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use complexes directly in abstract_sequence
2 participants