-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve grammar syntax #94
Merged
xtrojak
merged 14 commits into
sybila:improve-parsing
from
mopichalova:93-improve-grammar-syntax
Feb 26, 2024
Merged
Improve grammar syntax #94
xtrojak
merged 14 commits into
sybila:improve-parsing
from
mopichalova:93-improve-grammar-syntax
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtrojak
reviewed
Feb 21, 2024
xtrojak
reviewed
Feb 22, 2024
eBCSgen/Parsing/ParseBCSL.py
Outdated
Comment on lines
607
to
612
if key == 'inits': | ||
inits = value | ||
if key == 'definitions': | ||
definitions = value | ||
if key == 'regulation': | ||
regulation = value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there should be dict.update
again somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xtrojak
requested changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order of individual sections (rules, inits, etc) is arbitrary now to allow more flexibility
Enforcing and accepting newlines:
WS_INLINE
instead of allWS
Close #93