Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial version for survos/bunny-bundle #1711

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

initial version for survos/bunny-bundle #1711

wants to merge 6 commits into from
+33 −0

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Nov 18, 2024

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 18, 2024 13:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1711/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1711/index.json

  2. Install the package(s) related to this recipe:

    composer req symfony/flex
composer req 'survos/bunny-bundle:^1.5'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

auto-merge was automatically disabled November 18, 2024 13:51

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 18, 2024 13:52
auto-merge was automatically disabled November 18, 2024 13:55

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 18, 2024 13:55
auto-merge was automatically disabled November 18, 2024 14:09

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 18, 2024 14:10
fabpot
fabpot requested changes Nov 19, 2024
View reviewed changes
survos/bunny-bundle/1.5/post-install.txt
5. Only add the API keys you need to the production environment.



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we only need 1 whiteline?

survos/bunny-bundle/1.5/config/packages/survos_bunny.yaml Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 19, 2024 16:18

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 19, 2024 16:18
auto-merge was automatically disabled November 19, 2024 17:40

Head branch was pushed to by a user without write access

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 19, 2024 17:40
diimpp
diimpp reviewed Dec 5, 2024
View reviewed changes
survos/bunny-bundle/1.5/post-install.txt
Comment on lines +11 to +13



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp left review comments

@fabpot fabpot fabpot requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tacman @fabpot @diimpp