Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sylius/refund-plugin:2.0 Recipe #1728

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Dec 11, 2024

Q A
License MIT

To be merged after the release of sylius/refund-plugin:2.0.

Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1728/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1728/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'sylius/refund-plugin:^2.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

sylius/refund-plugin

0.4 vs 2.0
diff --git a/sylius/refund-plugin/0.4/config/packages/sylius_refund.yaml b/sylius/refund-plugin/2.0/config/packages/sylius_refund.yaml
index ce7ff8ae..5107d4fb 100644
--- a/sylius/refund-plugin/0.4/config/packages/sylius_refund.yaml
+++ b/sylius/refund-plugin/2.0/config/packages/sylius_refund.yaml
@@ -1,2 +1,2 @@
 imports:
-    - { resource: "@SyliusRefundPlugin/Resources/config/app/config.yml" }
+    - { resource: "@SyliusRefundPlugin/config/config.yaml" }
diff --git a/sylius/refund-plugin/0.4/config/routes/sylius_refund.yaml b/sylius/refund-plugin/2.0/config/routes/sylius_refund.yaml
index 46e99b16..e7ea95e4 100644
--- a/sylius/refund-plugin/0.4/config/routes/sylius_refund.yaml
+++ b/sylius/refund-plugin/2.0/config/routes/sylius_refund.yaml
@@ -1,2 +1,2 @@
 sylius_refund:
-    resource: "@SyliusRefundPlugin/Resources/config/routing.yml"
+    resource: "@SyliusRefundPlugin/config/routes.yaml"
diff --git a/sylius/refund-plugin/0.4/manifest.json b/sylius/refund-plugin/2.0/manifest.json
index 87516c74..74d5366f 100644
--- a/sylius/refund-plugin/0.4/manifest.json
+++ b/sylius/refund-plugin/2.0/manifest.json
@@ -4,5 +4,13 @@
     },
     "copy-from-recipe": {
         "config/": "%CONFIG_DIR%/"
-    }
+    },
+    "add-lines": [
+        {
+            "file": "assets/admin/entrypoint.js",
+            "content": "import '../../vendor/sylius/refund-plugin/assets/entrypoint';",
+            "position": "bottom",
+            "warn_if_missing": true
+        }
+    ]
 }

@fabpot
Copy link
Member

fabpot commented Dec 16, 2024

Still a draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants