Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "--version-prefix" option for Release Command #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jiangwennn
Copy link

No description provided.

@TomasVotruba
Copy link
Member

I'd say this is personal preference. Instead of changing this back and forth, we could have a configurable format. What do you think?

@jiangwennn
Copy link
Author

configurable format would be better, but I need some time to look through the code. I will try.

@jiangwennn jiangwennn changed the title fix: add release version prefix 'v' in resolveNextVersionByVersionKind feat: add "--version-prefix" option for Release Command Jul 27, 2023
@jiangwennn
Copy link
Author

@TomasVotruba Sorry to bother, but I got this question: I am currently working on a monorepo over php7.3, but this branch I submitted to is on php8.1 now. And I am not sure I will be able to use the new feature after this pull request is merged. Should I make another pull request to somewhere or .. ?

@kayw-geek
Copy link
Collaborator

@jiangwennn Thank you contribution, can you add some tests for the feature?

@onairmarc
Copy link

@jiangwennn @TomasVotruba is there any movement on this? Any chances to get this merged in so that tag prefixes can be added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants