fix: android tests

synonymdev · Mar 15, 2024 · 2fa8da3 · 2fa8da3
1 parent 3ba5659
commit 2fa8da3
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 15 deletions.
diff --git a/e2e/backup.e2e.js b/e2e/backup.e2e.js
@@ -81,7 +81,7 @@ d('Backup', () => {
 		await element(by.id('TagInput')).replaceText(tag);
 		await element(by.id('TagInput')).tapReturnKey();
 		await sleep(1000); // animation
-		await element(by.id('NavigationClose')).tap();
+		await element(by.id('NavigationClose')).atIndex(0).tap();
 
 		// change currency to GBP
 		await element(by.id('TotalBalance')).tap(); // switch to local currency

diff --git a/e2e/numberpad.e2e.js b/e2e/numberpad.e2e.js
@@ -91,7 +91,7 @@ d('NumberPad', () => {
 		await element(by.id('GeneralSettings')).tap();
 		await element(by.id('UnitSettings')).tap();
 		await element(by.id('DenominationClassic')).tap();
-		await element(by.id('NavigationClose')).tap();
+		await element(by.id('NavigationClose')).atIndex(0).tap();
 
 		await element(by.id('Receive')).tap();
 		if (await isVisible('UnderstoodButton')) {

diff --git a/e2e/security.e2e.js b/e2e/security.e2e.js
@@ -1,4 +1,5 @@
 import BitcoinJsonRpc from 'bitcoin-json-rpc';
+import { device } from 'detox';
 
 import {
 	sleep,
@@ -56,6 +57,11 @@ d('Settings Security And Privacy', () => {
 			return;
 		}
 
+		// skip test on Android we don't support bitometrics there
+		if (device.getPlatform() === 'android') {
+			return;
+		}
+
 		await device.setBiometricEnrollment(true);
 
 		await element(by.id('Settings')).tap();

diff --git a/e2e/settings.e2e.js b/e2e/settings.e2e.js
@@ -71,6 +71,12 @@ d('Settings', () => {
 			// switch back to sats
 			await element(by.id('TotalBalance')).tap();
 
+			// switch to USD
+			await element(by.id('Settings')).tap();
+			await element(by.id('GeneralSettings')).tap();
+			await element(by.id('CurrenciesSettings')).tap();
+			await element(by.text('USD ($)')).tap();
+
 			markComplete('settings-currency');
 		});
 
@@ -94,33 +100,33 @@ d('Settings', () => {
 			// check default unit
 			await expect(unitRow).toHaveText('Bitcoin');
 
-			// switch to GBP
+			// switch to USD
 			await element(by.id('UnitSettings')).tap();
-			await element(by.id('GBP')).tap();
-			await element(by.id('NavigationBack')).tap();
-			await expect(unitRow).toHaveText('GBP');
-			await element(by.id('NavigationClose')).tap();
-			await expect(fiatSymbol).toHaveText('£');
+			await element(by.id('USD')).tap();
+			await element(by.id('NavigationBack')).atIndex(0).tap();
+			await expect(unitRow).toHaveText('USD');
+			await element(by.id('NavigationClose')).atIndex(0).tap();
+			await expect(fiatSymbol).toHaveText('$');
 			await expect(balance).toHaveText('0.00');
 
 			// switch back to BTC
 			await element(by.id('Settings')).tap();
 			await element(by.id('GeneralSettings')).tap();
 			await element(by.id('UnitSettings')).tap();
 			await element(by.id('Bitcoin')).tap();
-			await element(by.id('NavigationBack')).tap();
+			await element(by.id('NavigationBack')).atIndex(0).tap();
 			await expect(unitRow).toHaveText('Bitcoin');
-			await element(by.id('NavigationClose')).tap();
+			await element(by.id('NavigationClose')).atIndex(0).tap();
 			await expect(balance).toHaveText('0');
 
 			// switch to classic denomination
 			await element(by.id('Settings')).tap();
 			await element(by.id('GeneralSettings')).tap();
 			await element(by.id('UnitSettings')).tap();
 			await element(by.id('DenominationClassic')).tap();
-			await element(by.id('NavigationBack')).tap();
+			await element(by.id('NavigationBack')).atIndex(0).tap();
 			await expect(unitRow).toHaveText('Bitcoin');
-			await element(by.id('NavigationClose')).tap();
+			await element(by.id('NavigationClose')).atIndex(0).tap();
 			await expect(balance).toHaveText('0.00000000');
 
 			markComplete('settings-unit');
@@ -242,7 +248,7 @@ d('Settings', () => {
 			await element(by.id('Settings')).tap();
 			await element(by.id('SecuritySettings')).tap();
 			await element(by.id('SwipeBalanceToHide')).tap();
-			await element(by.id('NavigationClose')).tap();
+			await element(by.id('NavigationClose')).atIndex(0).tap();
 
 			// Balance should be visible
 			await expect(element(by.id('ShowBalance'))).not.toBeVisible();
@@ -416,7 +422,7 @@ d('Settings', () => {
 			await waitFor(element(by.id('NavigationBack')).atIndex(0))
 				.toBeVisible()
 				.withTimeout(5000);
-			await element(by.id('NavigationBack')).tap();
+			await element(by.id('NavigationBack')).atIndex(0).tap();
 
 			await element(by.id('LightningNodeInfo')).tap();
 			// TODO: this fails too often on CI
@@ -673,7 +679,7 @@ d('Settings', () => {
 			await expect(element(by.id('Status-lightning_connection'))).toBeVisible();
 			await expect(element(by.id('Status-full_backup'))).toBeVisible();
 
-			await element(by.id('NavigationClose')).tap();
+			await element(by.id('NavigationClose')).atIndex(0).tap();
 
 			markComplete('settings-support-status');
 		});