Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Duplicated onchain receive notification #1577

Closed
pwltr opened this issue Feb 21, 2024 · 3 comments · Fixed by #1610
Closed

[Bug]: Duplicated onchain receive notification #1577

pwltr opened this issue Feb 21, 2024 · 3 comments · Fixed by #1610
Assignees
@coreyphillips
Labels
bug Something isn't working
Milestone
Beignet

Comments

@pwltr
Copy link
Collaborator

pwltr commented Feb 21, 2024

Describe the bug

After creating a fresh wallet I received onchain funds and the notification for it. After the next block it shows another notification for the same transaction.

Reproduce

  1. Receive onchain tx
  2. Hide receive notification
  3. Wait for next block
  4. See duplicated receive notification

Screenshots / Recording

Simulator.Screen.Recording.-.iPhone.14.-.2024-02-21.at.13.21.28.mp4

Operating system

iOS

Bitkit version

106

Log output

No response
@pwltr pwltr added bug Something isn't working triage This issue needs to be looked over by the team and removed triage This issue needs to be looked over by the team labels Feb 21, 2024
@pwltr
Copy link
Collaborator Author

pwltr commented Mar 12, 2024

@coreyphillips It looks like transactionReceived message is sent twice: once when seen in the mempool and another time when confirmed.

@JeanlChristophe JeanlChristophe added this to the Beignet milestone Mar 14, 2024
@coreyphillips
Copy link
Collaborator

Should be resolved as of this PR.

@pwltr pwltr linked a pull request Mar 19, 2024 that will close this issue
chore(wallet): Beignet Upgrade #1610
Merged
3 tasks
@pwltr
Copy link
Collaborator Author

pwltr commented Mar 19, 2024

Looks good, closing here.

@pwltr pwltr closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreyphillips coreyphillips

Labels
bug Something isn't working
Projects
None yet
Milestone
Beignet
Development

Successfully merging a pull request may close this issue.

chore(wallet): Beignet Upgrade synonymdev/bitkit
3 participants
@coreyphillips @pwltr @JeanlChristophe