Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wallet): Beignet Upgrade #1610

Merged
merged 1 commit into from
Mar 19, 2024
Merged

chore(wallet): Beignet Upgrade #1610

merged 1 commit into from
Mar 19, 2024

Conversation

coreyphillips
Copy link
Collaborator

Description

  • Upgrades beignet to 0.0.27.
  • Disables Bitkit's on-chain refresh when sats are received.
    • Beignet now handles this.
  • Adds check to prevent duplicate receive notifications.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (improving code without creating new functionality)

Tests

  • No test

@coreyphillips
chore(wallet): Beignet Upgrade
42c7479 
Upgrades beignet to 0.0.27.
Disables Bitkit's on-chain refresh when sats are received.
Adds check to prevent duplicate receive notifications.
@coreyphillips coreyphillips added bug Something isn't working beignet labels Mar 18, 2024
@coreyphillips coreyphillips added this to the Beignet milestone Mar 18, 2024
@coreyphillips coreyphillips self-assigned this Mar 18, 2024
@coreyphillips coreyphillips merged commit 6b27845 into master Mar 19, 2024
4 checks passed
@coreyphillips coreyphillips deleted the beignet-dep-upgrade branch March 19, 2024 10:53
@coreyphillips coreyphillips mentioned this pull request Mar 19, 2024
Closed
@pwltr pwltr linked an issue Mar 19, 2024 that may be closed by this pull request
[Bug]: Duplicated onchain receive notification #1577
Closed
@pwltr pwltr mentioned this pull request Mar 19, 2024
Closed
@pwltr pwltr linked an issue Mar 19, 2024 that may be closed by this pull request
[Bug]: Receive multiple payment notifications. #1155
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees

@coreyphillips coreyphillips

Labels
beignet bug Something isn't working
Projects
None yet
Milestone
Beignet
Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicated onchain receive notification [Bug]: Receive multiple payment notifications.
2 participants
@coreyphillips @limpbrains