feat(lightning): sync stored ldk txs with activity list #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyphillips
requested changes
Jul 26, 2023
src/utils/lightning/index.ts
Outdated
Comment on lines
1498
to
1557
| export const syncLightningTxsWithActivityList = async (): Promise< | ||
| Result<string> | ||
| > => { | ||
| let items: TLightningActivityItem[] = []; | ||
|
|
||
| const claimedTxs = await lm.getLdkPaymentsClaimed(); | ||
| for (const tx of claimedTxs) { | ||
| //Required to add in bolt11 and description | ||
| const invoice = await getPendingInvoice(tx.payment_hash); | ||
|
|
||
| items.push({ | ||
| id: tx.payment_hash, | ||
| activityType: EActivityType.lightning, | ||
| txType: EPaymentType.received, | ||
| message: invoice?.description ?? '', | ||
| address: invoice?.to_str ?? '', | ||
| confirmed: tx.state === 'successful', | ||
| value: tx.amount_sat, | ||
| timestamp: tx.unix_timestamp * 1000, | ||
| }); | ||
| } | ||
|
|
||
| const sentTxs = await lm.getLdkPaymentsSent(); | ||
| for (const tx of sentTxs) { | ||
| const sats = tx.amount_sat; | ||
| if (!sats) { | ||
| continue; | ||
| } | ||
|
|
||
| items.push({ | ||
| id: tx.payment_hash, | ||
| activityType: EActivityType.lightning, | ||
| txType: EPaymentType.sent, | ||
| message: '', | ||
| address: '', | ||
| confirmed: tx.state === 'successful', | ||
| value: -sats, | ||
| timestamp: tx.unix_timestamp * 1000, | ||
| }); | ||
| } | ||
|
|
||
| //TODO remove temp hack when this is complete and descriptions/bolt11 can be added from stored tx: https://github.com/synonymdev/react-native-ldk/issues/156 | ||
| items.forEach((item) => { | ||
| const res = getActivityItemById(item.id); | ||
| if (res.isOk()) { | ||
| const existingItem = res.value; | ||
| if (existingItem.activityType === EActivityType.lightning) { | ||
| item.message = existingItem.message; | ||
| item.address = existingItem.address; | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| dispatch({ | ||
| type: actions.UPDATE_ACTIVITY_ITEMS, | ||
| payload: items, | ||
| }); | ||
|
|
||
| return ok('Stored lightning transactions synced with activity list.'); | ||
| }; |
There was a problem hiding this comment.
To keep all dispatch actions together the syncLightningTxsWithActivityList method should be moved to src/store/actions/lightning.ts
There was a problem hiding this comment.
Fixed here 230ef2d
coreyphillips
previously approved these changes
Jul 27, 2023
|
Not sure why the tests are failing. |
coreyphillips
dismissed
their stale review
Channel seems to remain as pending in Bitkit
coreyphillips
approved these changes
Jul 27, 2023
Ah thanks might have been a race condition, channel was confirmed when I was testing receiving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues/Tasks
#1007
Type of change
Tests
QA Notes
Hoping incoming animation shows up but if it doesn't at least tx history won't be missing