Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recovery lightning backups from backup history #1190

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Conversation

Jasonvdb
Copy link
Collaborator

@Jasonvdb Jasonvdb commented Aug 8, 2023

Description

Allows users that restored from seed and skipped lightning restore (due to an error) to open the app in recovery mode and select a past backup from their backup history to restore from. On restore the backup will be loaded and LDK started with force closing all channels without broadcasting.

Linked Issues/Tasks

Add any links to GitHub issues or Asana tasks that are relevant to this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator Screenshot - iPhone 14 - 2023-08-08 at 10 53 13

QA Notes

If a restore fails or continues to crash, after making sure the channel was force closed by Blocktank we can attempt to restore from a past backup.

@coreyphillips coreyphillips self-requested a review August 9, 2023 13:20
@Jasonvdb Jasonvdb merged commit b5fcd49 into master Aug 10, 2023
4 checks passed
@Jasonvdb Jasonvdb deleted the restore-recovery branch August 10, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants