chore(lightning): Upgrade To Blocktank v2 API

[coreyphillips]

Description

Upgrades Bitkit to the Blocktank v2 API here.

[coreyphillips]

@limpbrains, any thoughts on why this test might be failing?

[limpbrains]

test expected QuickSetupReserveNote to be shown, but in reality QuickSetupBlocktankNote is shown. I've changed test to reflect it.
I've removed all sleep(1000), it is really not needed, when you run test with E2E=true.
Also test was failing with [BlocktankClientError: Failed to create order. "Channel size too big. Max size is USD999."] on the last step when buying big barrel on CustomSetup screen. Looks like a rounding bug in Bitkit ot Blocktank. I changed test to use medium barrel - $500. Maybe this needs to be fixed and reverted?

Here is a video of the test run:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-25.at.10.32.53.mp4

[coreyphillips]

Looks like the total channel size (incoming + receiving) was exceeding the maxChannelSizeSat value when the user opted for a spending value + the max receiving value in the custom flow. So in this commit and this commit we subtract any spending amount from the max receiving to ensure it remains under that limit in both Quick & Custom setups.

[coreyphillips]

I no longer understand how to appease the testing gods as @limpbrains did, but it's at least ready for review. @pwltr

[limpbrains]

Slider on the quick setup screen feels broken

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-26.at.09.21.50.mp4

[limpbrains]

Testing Gods are Pleased

[pwltr]

The custom setup flow is broken when selecting the maximum local balance:

Simulator.Screen.Recording.-.iPhone.14.-.2023-08-31.at.18.17.02.mp4

[coreyphillips]

Updated the calculations in this commit. Custom channels should get calculated correctly now no matter how many sats the user has.

[pwltr]

Fee is still incorrect here:

[pwltr]

I opened a channel with 80% spending balance and my receiving capacity is very small. I believe BT should always give me a balanced channel.

[coreyphillips]

I'm surprised Blocktank allowed that channel purchase. The new api usually does not allow the client balance to exceed the lsp balance with the following error: "clientBalanceSat is too big compared to lspBalanceSat. Max ratio: 1.".

In the latest commit, I've updated the QuickSetup component to set the max value on load to prevent the issue you posted above. I also adjusted the Cost: value to reflect the fee instead of the total sats needed to send to Blocktank.

Should be good to go for testing, just need to update the test script so that it passes with the new values for lightning onboarding.

[pwltr]

In the latest commit, I've updated the QuickSetup component to set the max value on load to prevent the issue you posted above.

I don't think we want to default to 80% from a design perspecive. Also it doesn't resolve the issue with the unbalanced channel for me.

I also adjusted the Cost: value to reflect the fee instead of the total sats needed to send to Blocktank.

This still doesn't show the correct amount:

[coreyphillips]

We've made it pretty far in this PR. I think we should call a checkpoint here so we can get some additional testing in with the new api and apply needed fixes in separate PR's from there

The Cost is the Blocktank fee. I don't believe we're able to calculate the cost of the transaction at this point. We might want to change the verbiage to "Blocktank Fee" or something similar.

The 80% is part of a larger discussion especially as anchor channels emerge.

[pwltr]

The Cost is the Blocktank fee. I don't believe we're able to calculate the cost of the transaction at this point. We might want to change the verbiage to "Blocktank Fee" or something similar.

This is working on the master branch. Unless I'm missing something I don't see the reason to introduce a regression here.

The 80% is part of a larger discussion especially as anchor channels emerge.

I don't understand the need for this change. The unbalanced channel issue is independent of the 80% limit. I'm unable to get a balanced channel with any spending amount. This really needs to be fixed otherwise BT v2 channels will be pretty much useless for receiving.

[coreyphillips]

The fee Cost discrepancy should be sorted as of the latest set of commits.

[coreyphillips]

Also increased the lsp balance when setting 0 sats on the clients end to something more usable. Should be good to go.

[pwltr]

Channel balancing seems better now, it's still defaulting to 80% spending balance in QuickSetup though. From my tests that doesn't affect balancing at all, and it's not in the design this way, so this should be reverted. Also there are a lot of leftover console logs.

[coreyphillips]

@pwltr Could you expand on this? Do you mean it's defaulting to a value greater than $1000 at 80%?
"It's still defaulting to 80% spending balance in QuickSetup though. From my tests that doesn't affect balancing at all, and it's not in the design this way"

[pwltr]

I'm talking about the slider on the QuickSetup screen, you've changed it to be set at 80% initially for a reason that is not apparent to me. It should be set to 20%.

[coreyphillips]

Gotcha. Updated here. Changed it from setting it to the max of 80% to 20%.

[pwltr]

Couple of nitpicks other than that LGTM