Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update widgets #1220

Merged
merged 1 commit into from
Sep 4, 2023
Merged

feat: update widgets #1220

merged 1 commit into from
Sep 4, 2023

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Aug 30, 2023

Description

Updates widgets UI to design prototype v39 and moves them to web-relay.

Linked Issues/Tasks

Replaces #1169
Closes #633
https://app.asana.com/0/0/1205132561089041/f

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

@pwltr pwltr force-pushed the widgets-next branch 7 times, most recently from 7ff9d47 to d9aa28e Compare September 1, 2023 11:16
@pwltr pwltr marked this pull request as ready for review September 1, 2023 13:21
@pwltr
Copy link
Collaborator Author

pwltr commented Sep 1, 2023

Looks like feeds are not reachable from CI for some reason.

@limpbrains
Copy link
Collaborator

Looking at the video from test run, I can see It can fetch feed description and later fails with "undefined is not a function" error

So, feeds are pretty much reachable

@pwltr
Copy link
Collaborator Author

pwltr commented Sep 2, 2023

Interesting, didn't know about the video for e2e tests!

Locally, tests keep hanging because of network requests to feeds:

09:19:05.693 detox[80834] i The app is busy with the following tasks:
• There are 1 work items pending on the dispatch queue: "Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)".
• Run loop "Main Run Loop" is awake.
• The event "Network Request" is taking place with object: "URL: “https://dht-relay.synonym.to/staging/web-relay/subscribe/azswe48ifp8gmk3p44e7futnxp6dxjm6izbgdyy96nqk8876xtty/Bitcoin%20Price/feed/BTCUSD-last”".
09:19:15.695 detox[80834] i The app is busy with the following tasks:
• There are 1 work items pending on the dispatch queue: "Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)".
• Run loop "Main Run Loop" is awake.
• The event "Network Request" is taking place with object: "URL: “https://dht-relay.synonym.to/staging/web-relay/subscribe/azswe48ifp8gmk3p44e7futnxp6dxjm6izbgdyy96nqk8876xtty/Bitcoin%20Price/feed/BTCUSD-last”".

I think event streams are not supported in detox, although I can't find anything on that when looking for similar issues.

EDIT: I forgot to set .env correctly, subscriptions are actually disabled for e2e tests, so this should not be the issue

@pwltr
Copy link
Collaborator Author

pwltr commented Sep 4, 2023

Tests are passing now except for LNURL e2e tests, but that's probably not because of anything in this PR. Should be ready for review @limpbrains

@pwltr pwltr force-pushed the widgets-next branch 2 times, most recently from 006ba25 to a5c6bb7 Compare September 4, 2023 16:32
@limpbrains
Copy link
Collaborator

I have same error on my machine:

error: Error: Unable to resolve module web-streams-polyfill/ponyfill/es6 from /Users/limp/s/bitkit/node_modules/react-native-polyfill-globals/src/readable-stream.js: web-streams-polyfill/ponyfill/es6 could not be found within the project or in these directories:
  node_modules
  ../../node_modules
  2 |
  3 | export const polyfill = () => {
> 4 |     const { ReadableStream } = require('web-streams-polyfill/ponyfill/es6');
    |                                         ^
  5 |
  6 |     polyfillGlobal('ReadableStream', () => ReadableStream);
  7 | };
    at ModuleResolver.resolveDependency (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:162:15)
    at DependencyGraph.resolveDependency (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/node-haste/DependencyGraph.js:260:43)
    at Object.resolve (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/lib/transformHelpers.js:177:21)
    at Graph._resolveDependencies (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:432:35)
    at Graph._processModule (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:218:38)
    at async Graph._addDependency (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:314:20)
    at async Promise.all (index 4)
    at async Graph._processModule (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:263:5)
    at async Graph._traverseDependenciesForSingleFile (/Users/limp/s/bitkit/node_modules/@react-native-community/cli-plugin-metro/node_modules/metro/src/DeltaBundler/Graph.js:207:5)
    at async Promise.all (index 0)

@pwltr
Copy link
Collaborator Author

pwltr commented Sep 4, 2023

Should be fixed now, just a small merge mistake.

@pwltr pwltr merged commit 9fd8ccc into master Sep 4, 2023
4 checks passed
@pwltr pwltr deleted the widgets-next branch September 4, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow multiple widgets of the same type
2 participants