-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: android e2e tests #1360
feat: android e2e tests #1360
Conversation
95c76e4
to
ee5b263
Compare
abdc98d
to
d212074
Compare
907da22
to
d404e5d
Compare
b7ec400
to
36f0a19
Compare
f84c928
to
1953665
Compare
22768d6
to
0909e94
Compare
80a7e35
to
5ba8396
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
e5c48b8
to
c747669
Compare
await waitFor(element(by.id('NewWallet'))).toBeVisible(); | ||
await sleep(100); // wtf? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that fixes it but according to docs waitFor
must have a withTimeout
otherwise it doesn't do anything.
await waitFor(element(by.id('NewWallet'))).toBeVisible(); | |
await sleep(100); // wtf? | |
await waitFor(element(by.id('NewWallet'))).toBeVisible().withTimeout(2000); | |
await sleep(100); // wtf? |
https://github.com/nubank/detox/blob/master/docs/APIRef.waitFor.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a link to outdated version of docs from 7 years ago.
I can't find anything like this on wix.github.io
https://wix.github.io/Detox/docs/api/expect
c747669
to
e7c9cf8
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Had to push an update, but before that there were a series of 5 uninterrupted successful test runs |
wtf
|
c4e7ace
to
2db263c
Compare
It's probably because of #1992, try changing it to |
Is it possible only do x86_64 build for detox tests? This might speedup the build/test |
yeah I think like this in detoxrc should work (just add the flag):
|
6b7024a
to
d4a7a3f
Compare
Reviewed the tests and CI runs. We can definitely make some improvements such as remvoing hard-coded waits in favour of checking e.g. that backups have succeeded, but it looks stable and the time saving is not worthwhile at this time. LGTM. |
Description
Type of change
Refactoring
Tests
Detox test