Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wallet): Beignet Migration - DO NOT MERGE #1437

Closed
wants to merge 1 commit into from

Conversation

coreyphillips
Copy link
Collaborator

DO NOT MERGE

Description

This PR migrates a majority of the on-chain wallet logic out of Bitkit.

I still need to merge in many changes since work started on this particular branch so please do not waste too much time on detailed code review at this time. What would be most valuable is testing to ensure feature parity along with feedback on how the logic has been migrated and Beignet implemented into Bitkit.

Implementation details:

  • Instead of migrating existing user wallet data to match Beignet's data structure I've opted instead to map Bitkit's existing data structure to Beignet's using the setWalletData & getWalletData methods. This allows all existing calls to Bitkit's store/state to remain intact and reduces the footprint of this PR.
  • Effectively, everything in the wallet store here is mapped accordingly with the exception of header, exchangeRates & feeEstimates that Beignet uses, but is stored elsewhere in Bitkit.

Known Bugs/Issues:

  • I still need to remove or update some state updates in Bitkit that overlap with Beignet setting the data. More specifically, I need to adjust the UPDATE_WALLET_DATA reducer here.

Type of change

  • Refactoring (improving code without creating new functionality)

Tests

  • No test

Migrates a majority of the on-chain wallet logic out of Bitkit.
@coreyphillips coreyphillips marked this pull request as draft December 19, 2023 00:54
@coreyphillips coreyphillips requested review from pwltr and limpbrains and removed request for limpbrains December 19, 2023 00:54
@coreyphillips coreyphillips removed the request for review from pwltr January 2, 2024 13:04
@limpbrains limpbrains deleted the experimental/beignet-migration branch January 2, 2024 13:12
@pwltr
Copy link
Collaborator

pwltr commented Jan 2, 2024

Accidentally closed @coreyphillips ? Otherwise lmk what/where I can test

@coreyphillips
Copy link
Collaborator Author

Negative, it was intentional. I have another branch on the way that will be current with the master branch.

@coreyphillips
Copy link
Collaborator Author

@pwltr New branch created here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants