Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade react-native to 0.73 #1447

Merged
merged 1 commit into from
Apr 1, 2024
Merged

chore: upgrade react-native to 0.73 #1447

merged 1 commit into from
Apr 1, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Dec 29, 2023

Description

https://reactnative.dev/blog/2023/12/06/0.73-debugging-improvements-stable-symlinks

Most notably Java 17 is now required to build Android version:

brew tap homebrew/cask-versions
brew install --cask zulu17

In case Android Studio complains about Gradle Plugin version you might have to update.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr
Copy link
Collaborator Author

pwltr commented Mar 28, 2024

Can I get a review here?

@pwltr pwltr requested a review from ovitrif March 28, 2024 12:50
Copy link
Collaborator

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should be merged after beignet release

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on both platforms seamless, though might be a good idea to keep beignet release separate of this, indeed.

@pwltr pwltr merged commit 660e5cc into master Apr 1, 2024
4 checks passed
@pwltr pwltr deleted the chore/upgrade-rn branch April 1, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants