Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env Templates #1532

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Update env Templates #1532

merged 2 commits into from
Feb 2, 2024

Conversation

coreyphillips
Copy link
Collaborator

Description

  • Adds empty string to TREASURE_HUNT_HOST in env templates to prevent "TREASURE_HUNT_HOST is not defined" errors when git cloning and installing.
  • Not sure if there's a better way to handle this?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

  • No test

Screenshot / Video

Simulator Screenshot - iPhone 14 - 2024-02-01 at 14 53 25

QA Notes

  • We should now be able to run the following command without an error resembling the attached screenshot.
git clone [email protected]:synonymdev/bitkit.git && cd bitkit && git checkout update-env-templates && yarn install && cd ios && pod install && cd ../ && yarn ios

Adds empty string to TREASURE_HUNT_HOST in env templates.
Adds space to empty string in env templates.
Copy link
Collaborator

@pwltr pwltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-native-dotenv has an option to allowUndefined

bitkit/babel.config.js

Lines 12 to 17 in 08c7a8c

'module:react-native-dotenv',
{
safe: true,
allowUndefined: false,
},
],

Not sure if that would be the better solution because we actually want the app to throw the above error for most env vars. I think I prefer the empty string.

@coreyphillips coreyphillips merged commit 009ab52 into master Feb 2, 2024
4 checks passed
@coreyphillips coreyphillips deleted the update-env-templates branch February 2, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants