fix(lightning): update transfer UI #1551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
force-pushed
the
fix/transfer-savings
branch
4 times, most recently
from
3090b45
to
fe0e5f8
Compare
pwltr
commented
Feb 9, 2024
pwltr
force-pushed
the
fix/transfer-savings
branch
from
fe0e5f8
to
d558994
Compare
This was
linked to
issues
Feb 9, 2024
Closed
Closed
Closed
coreyphillips
requested changes
Feb 10, 2024
src/store/actions/wallet.ts
Outdated
| pendingTransfers.forEach((transfer) => { | ||
| const tx = transactions[transfer.txId]; | ||
| if (transfer.confirmations <= 6) { | ||
| const confs = tx.height === -1 ? 1 : headerHeight - tx.height + 1; |
There was a problem hiding this comment.
Suggested change
| const confs = tx.height === -1 ? 1 : headerHeight - tx.height + 1; | |
| const confs = tx.height < 1 ? 0 : headerHeight - tx.height + 1; |
Seeing a confirmation miscalculation. Possibly from this snippet.
|
Other than that, everything LGTM! |
limpbrains
approved these changes
Feb 12, 2024
pwltr
force-pushed
the
fix/transfer-savings
branch
from
d558994
to
52fbd29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the UI to better show transfers from and to spending, also contains most of the design updates from v46 related to transfers. I moved some state related to transfers to its own field in
wallet.transfers, some of this is duplicated but this makes it more explicit and way easier to work with.Linked Issues/Tasks
Add any links to GitHub issues or Asana tasks that are relevant to this pull request.
Type of change
Tests
Screenshot / Video
channel open:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-09.at.16.06.10.mp4
channel close:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-09.at.16.00.27.mp4