-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lightning): update transfer UI #1553
Conversation
Also this error appeared:
|
Same happend when I've closed LN connection. After tx was confirmed and transfer was complete, I've opened Transfer flow and slider was not on the 0 position. After app restart everything was correct |
I think that needs to be addressed in RN-LDK, see #1261 I'll try to fix the other findings |
2c5404d
to
b134513
Compare
Can we fix this one ot it also requiers 1261 ? Simulator.Screen.Recording.-.iPhone.15.-.2024-02-12.at.13.22.08.mp4 |
b134513
to
56a6a0a
Compare
It should open the initial LN flow now instead of the transfer flow. |
56a6a0a
to
af785a9
Compare
tested: OK |
Description
Updates the UI to better show transfers from and to spending, also contains most of the design updates from v46 related to transfers. I moved some state related to transfers to its own field in
wallet.transfers
, some of this is duplicated but this makes it more explicit and way easier to work with.Linked Issues/Tasks
Add any links to GitHub issues or Asana tasks that are relevant to this pull request.
Type of change
Tests
Screenshot / Video
channel open:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-09.at.16.06.10.mp4
channel close:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-09.at.16.00.27.mp4