Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scan): remove prefix from Bitkit specific deep links #1622

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(scan): remove prefix from Bitkit specific deep links #1622

merged 1 commit into from
Mar 27, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Mar 27, 2024

Description

This allows the scanner to parse any deeplinks that use the bitkit:// scheme.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

For example:

npx uri-scheme open "bitkit://LNURL1DP68GURN8GHJ7CTSDYH8XARPVUHXYMR0VD4HGCTWDVH8GME0VFKX7CMTW3SKU6E0V9CXJTMKXGHKCTMZXQ6K2EPKX33Z6VECXENZ6DP3XGMJ6WRYV43Z6CENX5URSV3KXCMNSEF5P53WRA" --ios

@pwltr pwltr merged commit 1ac9934 into master Mar 27, 2024
4 checks passed
@pwltr pwltr deleted the fix/deep-link branch March 27, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @coreyphillips