feat(wallet): Implement Rust Address Generator #1627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes nodejs-mobile dependency and related files. Adds react-native-address-generator and implements it accordingly.
Updates react-native-address-generator to version 0.2.2. Updates Podfile.lock.
Upgrades react-native-mmkv to version 2.12.2.
…s-generator # Conflicts: # ios/Podfile.lock
|
@limpbrains, does the Can't seem to get it sorted. |
Removes wallet-restore.ts from tests. Adds setupAddressGenerator to setupOnChainWallet. Adds bip39Passphrase param to setupAddressGenerator.
…s-generator # Conflicts: # ios/Podfile.lock # yarn.lock
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Reverts EXCLUDED_ARCHS changes in project.pbxproj. Upgrades react-native-address-generator.
limpbrains
requested changes
Apr 22, 2024
| if (!addressGenerator) { | ||
| const res = await setupAddressGenerator({}); | ||
| if (res.isErr()) { | ||
| return ''; |
There was a problem hiding this comment.
Why return empty string instead of throwing an error? Who will handle this empty string?
There was a problem hiding this comment.
This is for react-native-ldk, in the event an issue occurred generating an address/scripthash since it only expects a string.
|
I'll be closing this PR in favor of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HODL! DO NOT MERGE
Description
nodejs-mobiledependency and related files.react-native-address-generatorand implements it accordingly.Linked Issues/Tasks
Type of change
Tests