feat: update design #1696
Merged
feat: update design #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sayem314/[email protected] |
limpbrains
requested changes
Apr 19, 2024
pwltr
force-pushed
the
feat/design
branch
3 times, most recently
from
21c1e83
to
4f8244c
Compare
pwltr
requested review from
coreyphillips and
limpbrains
and removed request for
rbndg
pwltr
force-pushed
the
feat/design
branch
3 times, most recently
from
0e171d9
to
71f84b3
Compare
This was
linked to
issues
Apr 23, 2024
|
Multiple "Advanced" & "Quick Setup" views get pushed to the navigation stack from the "Transfer Funds" view. Simulator.Screen.Recording.-.iPhone.15.-.2024-04-24.at.13.13.31.mp4 |
Fixed |
limpbrains
approved these changes
Apr 25, 2024
coreyphillips
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Except for a fix for 1684 it should only be visual changes, so probably just clicking through the UI makes the most sense for review. I did do some light refactoring and cleanups here and there, but no business logic has been touched.
hitSlopforPressables instead of negative margins@sayem314/react-native-keep-awakedependency asTimeoutscreen on transfer to spending not needed anymore<color />tags in translations files with generic<accent />TODO:
Linked Issues/Tasks
Closes #1684 #1634
#1629 (without discount UI)
Tests
I tested on iPhone 15, iPhone SE, Pixel 7
Screenshot / Video
QA Notes
Run the app with the Figma open on the side and look for design discrepancy like copy, spacing, colour, font issues etc.