Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ST v1 #1748

Merged
merged 2 commits into from
May 15, 2024
Merged

chore: remove ST v1 #1748

merged 2 commits into from
May 15, 2024

Conversation

limpbrains
Copy link
Collaborator

@limpbrains limpbrains commented Apr 26, 2024

Description

  • remove v1 -> v2 migration code
  • remove all v1 libs
  • remove ldk old restore
  • remove ldk recover screen
  • remove AuthWidget
  • remove old env variables
  • add error message if user tries to scan slashauth url

I will squash commits after review

Linked Issues/Tasks

Type of change

Refactoring

Tests

No test

QA Notes

Install prev version, add slashauth, upgrade, try to use slashauth. Widget should disapear

@Nuhvi
Copy link
Collaborator

Nuhvi commented May 12, 2024

@limpbrains I wonder if we should just merge this PR, test the performance of the app, to confirm that the DHT is causing most of the issues, then consider our options to add slashauth again in the light of that expirement.

@limpbrains
Copy link
Collaborator Author

Good idea, I will test it tomorrow

Copy link

socket-security bot commented May 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@limpbrains limpbrains force-pushed the stv1 branch 3 times, most recently from 53c1752 to 4740ef3 Compare May 14, 2024 14:29
@limpbrains limpbrains marked this pull request as ready for review May 15, 2024 09:49
tsconfig.json Outdated Show resolved Hide resolved
src/utils/i18n/locales/en/slashtags.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@pwltr pwltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Co-authored-by: Philipp Walter <[email protected]>
@limpbrains limpbrains merged commit 9d95153 into master May 15, 2024
6 checks passed
@limpbrains limpbrains deleted the stv1 branch May 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants