Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): add validation for quick setup numberpad #1784

Merged
merged 1 commit into from
May 6, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 3, 2024

Description

Adds validation for minimum amount when enter spending amount via numberpad in the QuickSetup.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-03.at.14.08.08.mp4

QA Notes

Make sure you can't continue with an invalid amount in the numberpad

@limpbrains
Copy link
Collaborator

e2e tests are failing

@pwltr pwltr force-pushed the fix/slider-custom-amount branch from fae800b to 3ccab06 Compare May 6, 2024 13:42
@pwltr pwltr requested a review from limpbrains May 6, 2024 14:18
@pwltr pwltr merged commit 47cc410 into master May 6, 2024
6 checks passed
@pwltr pwltr deleted the fix/slider-custom-amount branch May 6, 2024 15:31
@pwltr pwltr self-assigned this May 6, 2024
@catch-21
Copy link
Contributor

catch-21 commented May 23, 2024

Tested in b47d58d
LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants